fix(examples): author the four alert-dialog fixtures in the dialect the renderer reads (objectui#7693) - #7962

Fixes #7693

What was wrong

All four fixtures under examples/schema-catalog/src/schemas/components-overlay-alert-dialog/ authored their footer as an actions array of two button nodes. No surface carries that key:

• packages/components/src/renderers/overlay/alert-dialog.tsx:37 draws AlertDialogCancel only when schema.cancelText is truthy; :38 draws AlertDialogAction only when schema.actionText is truthy. schema.actions has zero read sites.
• AlertDialogSchema (packages/types/src/overlay.ts:89) and its zod twin (packages/types/src/zod/overlay.zod.ts:42) do not declare actions either.

So the four demos the docs page embeds through its SchemaExample host rendered a dialog with a header and an empty footer — including the one under the heading "With Custom Actions".

Nothing was red because BaseSchema is .passthrough() (packages/types/src/zod/base.zod.ts:241): actions rode through safeValidateSchema unvalidated, and no gate parses a JSON fixture as a schema.

The key set I measured on this base

origin/main at d39ede24e, after objectui#7104 (PR #7700, the declaration half) and objectui#7768 (trigger widened to a node array) had both landed.

Declared AND read — the dialect the fixtures now speak:
type, title, description, content, trigger, defaultOpen, open, cancelText, actionText, className. Plus the runtime slots onAction and onOpenChange, which are host-supplied functions with no JSON spelling — the zod twin refuses them by name.

Declared but read by nothing — deliberately not authored by any fixture:
cancelLabel, confirmLabel, confirmVariant. All three still exist on the declared face (overlay.ts:145-158, mirrored at overlay.zod.ts:60-62); the renderer reads none of them. Authoring a key that is only declared would trade one inert spelling for another.

The conversion, and the variant loss

Per fixture: actions[0] becomes cancelText, actions[1] becomes actionText. The per-button variant is dropped — the read dialect has no spelling for it, and the footer's styling is fixed by the primitives themselves (AlertDialogCancel always renders buttonVariants({ variant: 'outline' }), AlertDialogAction always the default). Three variants are lost: destructive on the confirm button of basic-alert-dialog and destructive-action, and ghost on the cancel button of confirmation-dialog. Trigger variants are untouched — those are ordinary button nodes the button renderer does read.

This follows the default route the triage comment adopted, quoted here in the original and not translated:

按读取方言转换,接受 variant 样式的丢失。 理由:一个渲染不出按钮的例子,严格劣于一个渲染得出按钮但少了 destructive 配色的例子。

Giving confirmVariant a read site is a renderer plus types change on the manual floor (domain:ui / domain:spec) and is explicitly out of this card's scope. It is not ridden along here, and no new card was opened for it — the triage comment already records the route and declines to open one.

custom-actions still demonstrates something of its own after the conversion — custom labels on both footer buttons rather than the palette's Cancel / Continue — so it is not a duplicate of basic-alert-dialog. It is kept regardless: the docs page references it by id, and deleting a referenced fixture is out of scope.

The pin

examples/schema-catalog/test/alert-dialog-footer-read-dialect-7693.test.tsx, both halves the triage comment listed, because they fail for different reasons:

1. DOM half — every fixture is rendered through the real registry (the overlay-trigger-mirror-6939.test.tsx harness, forced open with defaultOpen, since a closed Radix dialog mounts no content at all) and must draw at least one footer button carrying text.
2. Fixture-key half — a walk over the WHOLE catalog, not just these four, requiring that no alert-dialog node anywhere authors actions. This closes the class rather than the four files; today the catalog holds exactly these four alert-dialog nodes, so it needed no edit outside the anchor.

Each half carries a live control, because a render that draws nothing satisfies both assertions trivially:

• RENDERS_IN_THE_READ_DIALECT — an inline node in the read dialect must draw two footer buttons. If the harness cannot see a footer button at all, this reds first and every fixture row below means nothing.
• THE_PRE_REPAIR_SHAPE_DRAWS_NOTHING — the same node with an actions array and no label keys must draw zero footer buttons and still validate. That is the defect reproduced in one place, and it is what makes a red fixture row a reading about the spelling.
• Plus two anti-vacuity probes for the catalog walk: that it really reaches the four alert-dialog nodes, and that its offender predicate reports one when handed one.

It would have gone red on this base

Run before the fixtures were touched, with the branch at origin/main content:

Tests  5 failed | 8 passed (13)
  x basic-alert-dialog draws at least one footer button   AssertionError: expected 0 to be greater than or equal to 1
  x destructive-action  draws at least one footer button
  x confirmation-dialog draws at least one footer button
  x custom-actions      draws at least one footer button
  x the whole catalog is clean, not just the four the docs page embeds
      Expected []  Received [ 4 ids ]

Both controls were green in that same run, so the five reds are readings about the fixtures, not about the harness.

Ablation on the committed tree

destructive-action.json was restored to the actions shape at commit e25327f00, the mutation proven on disk before the run (actions count 1, cancelText count 0, actionText count 0; blob c461f143 differs from HEAD blob cfd178b2), then restored:

Tests  2 failed | 11 passed (13)
  x destructive-action draws at least one footer button
  x the whole catalog is clean, not just the four the docs page embeds
BACK_BLOB=cfd178b2064bbb5f5f25569eccf6143248c2ddb9   (== HEAD blob)
git diff HEAD after restore: []

Exactly the mutated fixture's row and the catalog-wide row went red; the other three fixture rows and both controls stayed green. The restore is proven by blob equality plus an empty git diff HEAD, not by an exit code.

The census that moved with it

examples/schema-catalog/test/form-control-dom-leak-5632.test.tsx asserts a per-type node census over the catalog, and button moves 126 to 118: the eight action-array button nodes are now two strings per fixture, so they leave a type-keyed walk. That table's own header sanctions exactly this ("These move when the CATALOG is authored, not when a renderer changes ... update them"); this diff touches no renderer, and noElement stays 0 everywhere.

Not touched

• content/docs/components/overlay/alert-dialog.mdx — verified, not assumed. Its Schema block was already corrected by PR fix(types): declare the four alert-dialog keys the renderer reads (objectui#7104) #7700 and lists cancelText / actionText with no actions row, and its prose at :46 describes the footer correctly ("the cancel button renders only when cancelText is set and the confirm button only when actionText is set"). No sentence there is wrong, so the page is left alone.
• No renderer, no packages/types.
• No changeset: node scripts/check-changeset-presence.mjs reports "6 file(s) changed, 0 of them published source of a package the release covers ... no changeset is owed" (examples/** is a private workspace).

Verification

All of the below on e25327f00 (working tree byte-identical to it, git diff HEAD empty).

turbo ls --affected from the branch base names two packages: @object-ui/example-schema-catalog (fully run above) and @object-ui/site, which is affected only because it depends on the catalog. The catalog's registry is typed as a Record keyed by STRING with Example values — written out in words rather than in angle brackets, because GitHub's body sanitizer eats short angle-bracket fragments even inside backticks — and Example leaves schema at unknown (examples/schema-catalog/src/index.ts:457, src/types.ts), so a JSON content change crosses that boundary with no type surface at all, and no example id was added or removed. The site's own type-check and next build are left to CI.

Heavy runs went through the shared verify lock; the wall-clock figures in its verdict lines are shared-box seconds.

Rework — the premise pin this card had to flip (added after the first CI run)

One sentence, since it is the substance of the rework: packages/types/src/__tests__/alert-dialog-read-dialect-7104.test.ts pinned this card's FILED PREMISE — that all four fixtures author actions and neither label key — precisely so the fix would have to come back and re-derive it, and the first push of this PR flipped the fixtures while leaving that pin, which is what turned CI's Test shard 4/4 red on four cases at :324.

That pin is now re-derived rather than deleted, because the file's own header prescribes re-derivation in those words: "Pinned here as that card's filed premise; its fix goes red here and re-derives the pin." The block now reads:

• each fixture authors cancelText and actionText as strings and no actions array;
• the UNION of every key the four fixtures author is a subset of AlertDialogZod.shape — membership in the mirror, which is the question .success cannot answer under .passthrough(), and which is not askable from the catalog package at all;
• two live controls: that actions is genuinely absent from shape (so the membership leg is not a tautology), and that the pre-repair document STILL parses green (so the reason nothing red covered this card stays a live reading, not a historical note).

The render-side half stays with the catalog and is deliberately not duplicated: neither package can host both, since packages/types cannot see a renderer and examples/schema-catalog cannot see the mirror's shape. The header bullet that listed this premise as UNRESOLVED is rewritten to record that it resolved and how. No face change — packages/types/src/overlay.ts and packages/types/src/zod/overlay.zod.ts are untouched, and git diff against the branch base names exactly eight files, none of them a declaration.

The standing line I had skipped

git grep -l 'components-overlay-alert-dialog' packages/ scripts/ examples/ apps/ — every reader of these fixtures:

Outside those four paths, content/docs/components/overlay/alert-dialog.mdx is the only other reference in the repo, and it is verified correct and untouched.

Ablation of the re-derived pin

confirmation-dialog.json restored to the actions shape on the committed tree, mutation proven on disk first (actions count 1, cancelText 0, actionText 0; blob ad076ac6 differs from HEAD blob ff9eb780):

Tests  2 failed | 40 passed (42)
  x confirmation-dialog.json authors `cancelText` and `actionText` and no `actions` array
  x every key any fixture authors is a MEMBER of the mirror — the reading passthrough used to hide
BACK_BLOB=ff9eb7800e19f8750b6913111010304637d71a5b   (== HEAD blob)
git diff HEAD after restore: []

Exactly the mutated fixture's row and the membership leg; both controls and the other three fixture rows stayed green.

Changeset, now owed

Editing any file under a released package's src/ owes a changeset, and the re-derived pin lives at packages/types/src/__tests__/. Nothing is published by it, so .changeset/alert-dialog-fixture-premise-pin-7693.md carries the EMPTY frontmatter the gate names as its explicit exemption: 1 changeset(s) ... Every one of them has an EMPTY frontmatter — declared as releasing nothing, which is the explicit exemption and a complete answer to this gate. check-changeset-no-major is green.

Re-run, at c070119cd

turbo ls --affected now names most of the tree, because turbo works at package granularity and the edited file sits under packages/types/src/. That fan-out is not real: the file is a leaf test, imported by nothing (git grep for its name outside itself finds one prose mention in a sibling test's comment and no import), so no downstream package's behaviour can move. The types package's own suite and the catalog's were both run in full above; the rest is left to CI.

Session reference, in prose and as a code span so it survives a body edit: https://claude.ai/code/session_013uAaxiwgYDybsTNV9xwa1M

Generated by Claude Code